Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Translate PWA #1856

Merged
merged 10 commits into from
Oct 23, 2024
Merged

feat: Translate PWA #1856

merged 10 commits into from
Oct 23, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Jun 6, 2024

Please close if this would represent too much of a burden. I open this prototype PR to maybe interest the team into translating the PWA, as it is now used/useable in production.

Depends on frappe/frappe#24435

no-docs

@cogk cogk requested a review from ruchamahabal as a code owner June 6, 2024 16:02
@cogk cogk marked this pull request as draft June 6, 2024 16:03
@ruchamahabal ruchamahabal self-assigned this Jun 6, 2024
frontend/src/translatePlugin.js Outdated Show resolved Hide resolved
@cogk cogk marked this pull request as ready for review July 5, 2024 15:32
@krantheman
Copy link
Member

Looks good

Can you fix conflicts? And add translations for the new Attendance Dasboard as well?

@cogk
Copy link
Contributor Author

cogk commented Oct 17, 2024

@krantheman Yes!

@krantheman krantheman merged commit 87561a2 into frappe:develop Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants