-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Translate PWA #1856
Merged
Merged
feat: Translate PWA #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogk
commented
Jun 6, 2024
cogk
force-pushed
the
feat-translate-pwa
branch
from
August 22, 2024 12:26
59bae63
to
005317e
Compare
cogk
force-pushed
the
feat-translate-pwa
branch
from
September 19, 2024 11:39
fdc1c3e
to
578d7aa
Compare
Looks good Can you fix conflicts? And add translations for the new Attendance Dasboard as well? |
@krantheman Yes! |
cogk
force-pushed
the
feat-translate-pwa
branch
from
October 17, 2024 12:20
578d7aa
to
278a003
Compare
krantheman
reviewed
Oct 22, 2024
krantheman
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please close if this would represent too much of a burden. I open this prototype PR to maybe interest the team into translating the PWA, as it is now used/useable in production.
Depends on frappe/frappe#24435