feat: Allow salary slip preview for draft salary structure assignments #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromonav
suggested changes
May 30, 2024
| @@ -725,14 +725,14 @@ def add_earning_for_hourly_wages(self, doc, salary_component, amount): | |||
| } | |||
| doc.append("earnings", wages_row) | |||
|
|
|||
| def set_salary_structure_assignment(self): | |||
| def set_salary_structure_assignment(self,docstatus=1): | |||
There was a problem hiding this comment.
can we also allow passing any custom salary structure assignment?
Just passing in draft would not allow use the preview salary slip for a particular salary structure assignment
|
Also we will need to do changes in the exposed API. |
chromonav
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces functionality to preview salary slips for draft salary structure assignments. It includes the following changes:
Issue: #1823