fix(Auto Attendance): incorrect previous shift computation for a timestamp leading to incorrect absent marking #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
ruchamahabal
force-pushed
the
fix-absent-marking-logic
branch
2 times, most recently
from
3f1d5c6
to
4a05706
Compare
…stamp leading to incorrect absent marking
ruchamahabal
force-pushed
the
fix-absent-marking-logic
branch
from
4a05706
to
ab2f109
Compare
ruchamahabal
added
backport version-14-hotfix
backport version-15-hotfix
and removed
needs-tests
labels
This was referenced May 7, 2024
This was referenced May 7, 2024
Closed
ruchamahabal
added a commit
that referenced
this pull request
May 7, 2024
…1703 fix(Auto Attendance): incorrect previous shift computation for a timestamp leading to incorrect absent marking (backport #1703)
ruchamahabal
added a commit
that referenced
this pull request
May 7, 2024
…1703 fix(Auto Attendance): incorrect previous shift computation for a timestamp leading to incorrect absent marking (backport #1703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 consecutive day shifts overlapping in timings
Assigned to the same employee
Problem 1
Marks employee as absent even before last sync of check-in due to a bug in fetching previous shifts if there are missing employee checkins
Problem 2
Also if you create a check-in record in the grace ending period of the current shift (General Shift) - let's say 18:30:00
Actual Start would get set as 18:00:00 for this record although start is actually 07:00 so actual start should be 05:00. This only happens when the check-in timestamp falls in a period of current shift which is not valid on previous day's shift. So ideally
prev_shiftshould have been NoneThis same fix fixes both of these cases. While getting relevant shifts, it resets the end date to not go beyond the
for_timestamp.