refactor: use frappe.delete_doc instead of frappe.db.delete

frappe · Jun 17, 2024 · e6f9bba · e6f9bba
1 parent 6b60596
commit e6f9bba
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/hrms/api/roster.py b/hrms/api/roster.py
@@ -63,7 +63,11 @@ def create_shift_assignment_schedule(
 
 @frappe.whitelist()
 def delete_shift_assignment_schedule(schedule: str) -> None:
-	frappe.db.delete("Shift Assignment", {"schedule": schedule})
+	for shift_assignment in frappe.get_all("Shift Assignment", {"schedule": schedule}, pluck="name"):
+		doc = frappe.get_doc("Shift Assignment", shift_assignment)
+		if doc.docstatus == 1:
+			doc.cancel()
+		frappe.delete_doc("Shift Assignment", shift_assignment)
 	frappe.delete_doc("Shift Assignment Schedule", schedule)