Merge pull request #2316 from frappe/mergify/bp/version-15/pr-2303

fix(Employee Checkin): Fetch Geolocation (backport #2303)
frappe · Oct 21, 2024 · 30768b0 · 30768b0
2 parents 37fb469 + 1de53e2
commit 30768b0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/hrms/hr/doctype/employee_checkin/employee_checkin.py b/hrms/hr/doctype/employee_checkin/employee_checkin.py
@@ -24,7 +24,7 @@ def validate(self):
 		validate_active_employee(self.employee)
 		self.validate_duplicate_log()
 		self.fetch_shift()
-		set_geolocation_from_coordinates(self)
+		self.set_geolocation()
 		self.validate_distance_from_shift_location()
 
 	def validate_duplicate_log(self):
@@ -43,6 +43,10 @@ def validate_duplicate_log(self):
 				_("This employee already has a log with the same timestamp.{0}").format("<Br>" + doc_link)
 			)
 
+	@frappe.whitelist()
+	def set_geolocation(self):
+		set_geolocation_from_coordinates(self)
+
 	@frappe.whitelist()
 	def fetch_shift(self):
 		if not (

diff --git a/hrms/public/js/utils/index.js b/hrms/public/js/utils/index.js
@@ -197,7 +197,7 @@ $.extend(hrms, {
 				frm.set_value("latitude", position.coords.latitude);
 				frm.set_value("longitude", position.coords.longitude);
 
-				await frm.call("hrms.hr.utils.set_geolocation_from_coordinates");
+				await frm.call("set_geolocation");
 				frappe.dom.unfreeze();
 			},
 			(error) => {