Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add QEMU action #737

Merged
merged 2 commits into from
Mar 28, 2022
Merged

add QEMU action #737

merged 2 commits into from
Mar 28, 2022

Conversation

restlessronin
Copy link
Contributor

@restlessronin restlessronin commented Mar 28, 2022 •
edited
Loading

update build-push separately. once this is merged into main, it can be used by the images-for-m1-mac to test the full image build.

Hopefully, it's clear the changes are benign and can be merged.

restlessronin
restlessronin commented Mar 28, 2022
View reviewed changes
Copy link
Contributor Author

@restlessronin restlessronin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing this does is setup QEMU and update the bake action to the latest version. Should be safe to merge.

@restlessronin restlessronin mentioned this pull request Mar 28, 2022
Merged
revant
revant approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@revant revant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vrslev merge?

@vrslev vrslev merged commit 21fdeee into frappe:main Mar 28, 2022
@vrslev vrslev mentioned this pull request Apr 11, 2022
Closed
TheRealJim1 pushed a commit to TheRealJim1/frappe_docker that referenced this pull request Jul 26, 2024
@restlessronin
add QEMU action (frappe#737)
b2d2809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revant revant revant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@restlessronin @revant @vrslev