Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create repost payment ledger entries from the report for differerences #44268

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vorasmit
Copy link
Collaborator

Issue

  • Repost entries created for all vouchers could be less performant and unnecessary
  • End user may be less confident / unaware of how to use the repost feature

Fix

Create repost entries from Report General and Payment Ledger Comparison only for the entries with differences

Video

create-repost-entries.mp4

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 21, 2024
@ruthra-kumar
Copy link
Member

ruthra-kumar commented Nov 22, 2024

Nice work @vorasmit

I see you are trying to liven up contributions with soundtracks 😄

@ruthra-kumar
Copy link
Member

ruthra-kumar commented Nov 22, 2024

@vorasmit

End user may be less confident / unaware of how to use the repost feature

On this point, I do have some context to share. I developed this report primarily as a debugging tool. This in-combination with the Reposting functionality serves as a very effective way to handle ledger discrepancies.

Having said that, I think we should discourage end users from using this regularly. They might end up developing a habit of patching data for the moment, rather than identifying the root cause.

@vorasmit
Copy link
Collaborator Author

I agree. Fixing core issues is more important that giving a better UX. Your call. We can close this for now, and re-open this when we fell more of such issues are because of customisations and not core bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants