Fix: Disable "Add Row" button in allocations table during UnReconcile process #44148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmakanthKaspa
force-pushed
the
bugfix-disable-add-rows-allocations-table
branch
from
c328060
to
13ca270
Compare
ruthra-kumar
approved these changes
Nov 15, 2024
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
added a commit
that referenced
this pull request
Nov 15, 2024
…-44148 Fix: Disable "Add Row" button in allocations table during UnReconcile process (backport #44148)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 15, 2024
…-44148 Fix: Disable "Add Row" button in allocations table during UnReconcile process (backport #44148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In the UnReconcile Allocations dialog, the
cannot_add_rowsproperty was incorrectly applied to the dialog itself, which did not prevent users from adding rows to the allocations table.Solution:
The
cannot_add_rowsproperty has been moved and correctly applied to the allocations table field to disable the "Add Row" button, ensuring users cannot add new rows while reconcilingBefore:
After: