Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set default filter dates if missing #36597

Merged
merged 1 commit into from
Aug 11, 2023
Merged

chore: set default filter dates if missing #36597

merged 1 commit into from
Aug 11, 2023

Conversation

anandbaburajan
Copy link
Contributor

@anandbaburajan anandbaburajan commented Aug 11, 2023

Fixed Asset Register report with missing dates for Date Range or Fiscal Year method results in a frappe.exceptions.ValidationError: Start Year and End Year are mandatory error. So setting default dates.

Fixes #36419.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 11, 2023
@anandbaburajan anandbaburajan enabled auto-merge (squash) August 11, 2023 08:19
@anandbaburajan anandbaburajan merged commit 98e82e0 into frappe:develop Aug 11, 2023
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
anandbaburajan added a commit that referenced this pull request Aug 11, 2023
chore: set default filter dates if missing (#36597)

(cherry picked from commit 98e82e0)

Co-authored-by: Anand Baburajan <[email protected]>
anandbaburajan added a commit that referenced this pull request Aug 11, 2023
chore: set default filter dates if missing (#36597)

(cherry picked from commit 98e82e0)

Co-authored-by: Anand Baburajan <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asset workspace error (fiscal year)
1 participant