Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PermissionError in Work Order #34953

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: PermissionError in Work Order #34953

merged 2 commits into from
Apr 20, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Apr 20, 2023 •
edited
Loading

Source / Ref: ISS-23-24-00209

Use __onload to get the value in JS instead of get_doc.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 20, 2023
@s-aga-r s-aga-r force-pushed the FIX-ISS-23-24-00209 branch from 9e10f9c to f3c0eca Compare April 20, 2023 07:56
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Merging #34953 (f3c0eca) into develop (ea6eeac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f3c0eca differs from pull request most recent head 81653e4. Consider uploading reports for the commit 81653e4 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #34953   +/-   ##
========================================
  Coverage    63.87%   63.87%           
========================================
  Files          810      810           
  Lines        59750    59751    +1     
========================================
+ Hits         38167    38168    +1     
  Misses       21583    21583
Impacted Files Coverage Δ
...ext/manufacturing/doctype/work_order/work_order.py 80.90% <100.00%> (+0.02%) ⬆️

@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Apr 20, 2023
@s-aga-r s-aga-r force-pushed the FIX-ISS-23-24-00209 branch from f3c0eca to 8108b2d Compare April 20, 2023 10:11
@s-aga-r s-aga-r marked this pull request as ready for review April 20, 2023 10:27
@s-aga-r s-aga-r merged commit 76c4d90 into frappe:develop Apr 20, 2023
This was referenced Apr 20, 2023
Merged
Merged
s-aga-r added a commit that referenced this pull request Apr 20, 2023
@s-aga-r
Merge pull request #34957 from frappe/mergify/bp/version-13-hotfix/pr…
ebf8deb 
…-34953

fix: `PermissionError` in Work Order (backport #34953)
s-aga-r added a commit that referenced this pull request Apr 20, 2023
@s-aga-r
Merge pull request #34956 from frappe/mergify/bp/version-14-hotfix/pr…
11e4fcb 
…-34953

fix: `PermissionError` in Work Order (backport #34953)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-aga-r @rohitwaghchaure