Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary checkbox from Accounts doctype #34821

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 11, 2023

Removed unnecessary checkbox from Accounts doctype. There used to be a checkbox in Accounts Doctype for "Inter Company Account", this field didn't do anything specific so removing this check.

ToDo

  • Update docs

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #34821 (7772049) into develop (c957a5c) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34821      +/-   ##
===========================================
+ Coverage    63.84%   63.87%   +0.02%     
===========================================
  Files          810      810              
  Lines        59721    59722       +1     
===========================================
+ Hits         38129    38145      +16     
+ Misses       21592    21577      -15     

see 4 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Apr 14, 2023
@deepeshgarg007 deepeshgarg007 merged commit 6613049 into frappe:develop Apr 14, 2023
mergify bot pushed a commit that referenced this pull request Apr 14, 2023
deepeshgarg007 added a commit that referenced this pull request Apr 14, 2023
fix: Remove unnecessary checkbox from Accounts doctype (#34821)

(cherry picked from commit 6613049)

Co-authored-by: Deepesh Garg <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Apr 19, 2023
# [14.22.0](v14.21.0...v14.22.0) (2023-04-19)

### Bug Fixes

* Add offers info to website item ([#34873](#34873)) ([f1a1fc6](f1a1fc6))
* Advance payment against payment terms ([#34872](#34872)) ([7461239](7461239))
* change discuss forum url ([#34891](#34891)) ([8f26d62](8f26d62))
* don't show disabled warehouses in the Warehouse Wise Stock Balance report ([461780d](461780d))
* Don't use stale item details ([#34847](#34847)) ([c11aeba](c11aeba))
* for Tree Type item and item group show net amount ([#31776](#31776)) ([7c8194a](7c8194a))
* linters issues ([c53dc06](c53dc06))
* Remove unnecessary checkbox from Accounts doctype ([#34821](#34821)) ([0cf6144](0cf6144))
* selling workspace is not migrating properly ([79fd38c](79fd38c))
* stock reco test case ([2f356dc](2f356dc))
* too many writes error while making backdated stock reconciliation ([a981b79](a981b79))
* unable to change `company` for manual `Serial No` entry ([2e7043c](2e7043c))
* **ux:** don't throw error when company defaults aren't set ([#34825](#34825)) ([15f5e8d](15f5e8d))
* whitelist doc method ([09b92fd](09b92fd))

### Features

* add german sales tax template ([#34823](#34823)) ([3738ea5](3738ea5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant