Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reconcile Payments in background #34596

Merged
merged 63 commits into from
Apr 22, 2023
Merged

feat: Reconcile Payments in background #34596

merged 63 commits into from
Apr 22, 2023

Commits on Apr 20, 2023

  1. feat: auto reconcile in background

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9851358 View commit details
    Browse the repository at this point in the history

  2. chore: Option to enable auto reconciliation in settings

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    67dcd44 View commit details
    Browse the repository at this point in the history

  3. refactor: validate if feature is enabled in settings

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9e7e392 View commit details
    Browse the repository at this point in the history

  4. refactor: check for running job while using reconciliation tool

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    05f25a6 View commit details
    Browse the repository at this point in the history

  5. chore: using doc to get filter values

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    767cda1 View commit details
    Browse the repository at this point in the history

  6. chore: use frappe.db.get_value in validations

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9649b6b View commit details
    Browse the repository at this point in the history

  7. chore: cleanup commented out code

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4e945d4 View commit details
    Browse the repository at this point in the history

  8. chore: replace get_list with get_all

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5cd97cf View commit details
    Browse the repository at this point in the history

  9. chore: use block scope variable

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a6d7eff View commit details
    Browse the repository at this point in the history

  10. chore: type information for functions

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e92cc2d View commit details
    Browse the repository at this point in the history

  11. refactor: flag to ignore job validation check

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8c7a20a View commit details
    Browse the repository at this point in the history

  12. refactor: update parent doc status if all reconciled

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8e2c7bc View commit details
    Browse the repository at this point in the history

  13. chore: create test_records file

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    01038a4 View commit details
    Browse the repository at this point in the history

  14. test: create a bunch of vouchers for testing auto reconcile

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a2fb9bd View commit details
    Browse the repository at this point in the history

  15. chore: renamed auto_reconcile to process_payment_reconciliation

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c50aa38 View commit details
    Browse the repository at this point in the history

  16. chore: another child doctype to hold payments

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a4d3d7b View commit details
    Browse the repository at this point in the history

  17. chore: remove duplicate field

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b17486d View commit details
    Browse the repository at this point in the history

  18. chore: add fetched payments to log

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0c022ca View commit details
    Browse the repository at this point in the history

  19. chore: Popup comment message update

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    025ab20 View commit details
    Browse the repository at this point in the history

  20. chore: replace get_all with get_value

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9d23c30 View commit details
    Browse the repository at this point in the history

  21. chore: replace label in settings page

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3d9733f View commit details
    Browse the repository at this point in the history

  22. chore: remove unit test and records

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6a4f1ef View commit details
    Browse the repository at this point in the history

  23. refactor: status in reconciliation log

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    457128c View commit details
    Browse the repository at this point in the history

  24. refactor: set status in log as well

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c65695c View commit details
    Browse the repository at this point in the history

  25. chore: fix field name

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9afb2e8 View commit details
    Browse the repository at this point in the history

  26. chore: change triggered job name

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    898c198 View commit details
    Browse the repository at this point in the history

  27. chore: use status field in list view of log

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    da46565 View commit details
    Browse the repository at this point in the history

  28. chore: status while there are no allocations

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ec2914b View commit details
    Browse the repository at this point in the history

  29. refactor: split trigger function into two

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c4f151b View commit details
    Browse the repository at this point in the history

  30. chore: adding cancelled status

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1c21c7d View commit details
    Browse the repository at this point in the history

  31. refactor: function trigger queued docs

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ea74670 View commit details
    Browse the repository at this point in the history

  32. chore: cron job scheduled

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    569a1f3 View commit details
    Browse the repository at this point in the history

  33. chore: fixing accouts settings json file

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b9b4faf View commit details
    Browse the repository at this point in the history

  34. chore: typos and variable scope

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1ee0c7b View commit details
    Browse the repository at this point in the history

  35. chore: use 'pluck' in db call

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bace8f8 View commit details
    Browse the repository at this point in the history

  36. chore: remove redundant whitelist decorator

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0aa87ee View commit details
    Browse the repository at this point in the history

  37. chore: use single DB call to fetch values

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    187291e View commit details
    Browse the repository at this point in the history

  38. chore: replace get_all with get_value

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    32c554d View commit details
    Browse the repository at this point in the history

  39. refactor: use raw db calls to fetch reconciliation log records 

    Using get_doc on `Process Payment Reconciliation Log` is costly when
handling large volumes of invoices.

Use raw frappe.db.get_all to selectively pull status and reconciled count
    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    676f0c1 View commit details
    Browse the repository at this point in the history

  40. chore: update status on successful batch operation

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    cf2ac29 View commit details
    Browse the repository at this point in the history

  41. chore: make payment table readonly

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c5629c2 View commit details
    Browse the repository at this point in the history

  42. chore: ability to pause the background job

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ded7b73 View commit details
    Browse the repository at this point in the history

  43. chore: remove isolate_each_allocation

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    da13782 View commit details
    Browse the repository at this point in the history

  44. chore: more description in progress bar

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    385f0af View commit details
    Browse the repository at this point in the history

  45. refactor: partially working state

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9fb4509 View commit details
    Browse the repository at this point in the history

  46. refactor: update reconcile flag and setting hard limits for fetching

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    62a6ca4 View commit details
    Browse the repository at this point in the history

  47. chore: make allocation editable -- NEED TO REVERT

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f23ac7a View commit details
    Browse the repository at this point in the history

  48. chore: pause button

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5c2f26d View commit details
    Browse the repository at this point in the history

  49. refactor: skip setter function in Payment Entry for better performan

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ddc699d View commit details
    Browse the repository at this point in the history

  50. refactor: split reconcile function and skip a setter function 

    1. Split reconcile function into 2
2. While reconciling against payment entry, skip a
set_missing_ref_details setter method
    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7250772 View commit details
    Browse the repository at this point in the history

  51. chore: increase payment limit

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b729714 View commit details
    Browse the repository at this point in the history

  52. refactor: replace frappe.db.get_all with frappe.db.get_value

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6b8b6f8 View commit details
    Browse the repository at this point in the history

  53. chore: remove unwanted doctypes

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4047494 View commit details
    Browse the repository at this point in the history

  54. refactor: make allocation table readonly

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0b8d0bd View commit details
    Browse the repository at this point in the history

  55. perf: update ref_details only for newly linked invoices

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    170c63b View commit details
    Browse the repository at this point in the history

  56. chore: rename skip flag

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0b930e0 View commit details
    Browse the repository at this point in the history

  57. refactor(UI): receivable_payable field should auto populate

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dfecf49 View commit details
    Browse the repository at this point in the history

  58. refactor: no control statements in finally block

    @ruthra-kumar
    ruthra-kumar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0c4cd7c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. chore: cleanup section and rename checkbox

    @ruthra-kumar
    ruthra-kumar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    81e57ec View commit details
    Browse the repository at this point in the history

  2. chore: update new fieldname in code

    @ruthra-kumar
    ruthra-kumar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1d73e92 View commit details
    Browse the repository at this point in the history

  3. chore: update error msg

    @ruthra-kumar
    ruthra-kumar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    68f2e0d View commit details
    Browse the repository at this point in the history

  4. refactor: start and pause integrated into status 

    pause checkbox has been removed
    @ruthra-kumar
    ruthra-kumar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b46aa3e View commit details
    Browse the repository at this point in the history

  5. refactor: added cancelled status to the log doctype 

    1. Moved the status section to the bottom in parent doc
2. Using alerts to indicate Job trigger status
    @ruthra-kumar
    ruthra-kumar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f99d479 View commit details
    Browse the repository at this point in the history