Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default enabled 'Automatically Fetch Payment Terms from Order' in accounts settings #32617

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

When you make purchase invoice from the purchase order then system won't fetch the Payment Terms from the Purchase Order to Purchase Invoice if the "Automatically Fetch Payment Terms from Order" checkbox has disabled in the Accounts Settings.

Solution

Make default behaviour enabled "Automatically Fetch Payment Terms from Order" in the Accounts Setting

@bosue
Copy link
Contributor

bosue commented Nov 9, 2023

Enabling this setting by default makes a lot of sense. One might even ask why this switch exists at all.

It is really hard to see a reason someone would create a Sales Order with Payment Terms, but then wouldn‘t want these Payment Terms be preserved when creating the Sales Invoice.

See for example this: #36108. Even devops don‘t expect this to be just an optional feature. It‘s so much expected that people would try and come up with a PR to implement a feature deemed missing.

There used to be a few rough edges, bust most of them have been fixed, such as #35285, and if any problems remain, these will have to be fixed anyway.

For all these reasons, I really think this PR should be reopened!

Edit: one remaining bug I found, is #38030.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants