Skip to content

Commit

Permalink
Merge pull request #44025 from Ninad1306/disable_rounded_total_for_qu…
Browse files Browse the repository at this point in the history
…otation
  • Loading branch information
vorasmit authored Nov 18, 2024
2 parents 806ec72 + 5a6261d commit 2ada270
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 6 deletions.
21 changes: 15 additions & 6 deletions erpnext/selling/doctype/quotation/quotation.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"grand_total",
"rounding_adjustment",
"rounded_total",
"disable_rounded_total",
"in_words",
"section_break_44",
"apply_discount_on",
Expand Down Expand Up @@ -663,6 +664,7 @@
"width": "200px"
},
{
"depends_on": "eval:!doc.disable_rounded_total",
"fieldname": "base_rounding_adjustment",
"fieldtype": "Currency",
"label": "Rounding Adjustment (Company Currency)",
Expand Down Expand Up @@ -711,6 +713,7 @@
"width": "200px"
},
{
"depends_on": "eval:!doc.disable_rounded_total",
"fieldname": "rounding_adjustment",
"fieldtype": "Currency",
"label": "Rounding Adjustment",
Expand Down Expand Up @@ -1073,23 +1076,29 @@
},
{
"fieldname": "utm_medium",
"print_hide": 1,
"fieldtype": "Link",
"label": "Medium",
"options": "UTM Medium"
"options": "UTM Medium",
"print_hide": 1
},
{
"fieldname": "utm_content",
"print_hide": 1,
"fieldtype": "Data",
"label": "Content"
"label": "Content",
"print_hide": 1
},
{
"default": "0",
"fieldname": "disable_rounded_total",
"fieldtype": "Check",
"label": "Disable Rounded Total"
}
],
"icon": "fa fa-shopping-cart",
"idx": 82,
"is_submittable": 1,
"links": [],
"modified": "2024-06-28 10:32:47.638342",
"modified": "2024-11-07 18:37:11.715189",
"modified_by": "Administrator",
"module": "Selling",
"name": "Quotation",
Expand Down Expand Up @@ -1187,4 +1196,4 @@
"states": [],
"timeline_field": "party_name",
"title_field": "title"
}
}
1 change: 1 addition & 0 deletions erpnext/selling/doctype/quotation/quotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class Quotation(SellingController):
customer_address: DF.Link | None
customer_group: DF.Link | None
customer_name: DF.Data | None
disable_rounded_total: DF.Check
discount_amount: DF.Currency
enq_det: DF.Text | None
grand_total: DF.Currency
Expand Down
14 changes: 14 additions & 0 deletions erpnext/selling/doctype/quotation/test_quotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,20 @@ def test_item_tax_template_for_quotation(self):
item_doc.taxes = []
item_doc.save()

def test_grand_total_and_rounded_total_values(self):
quotation = make_quotation(qty=6, rate=12.3, do_not_submit=1)

self.assertEqual(quotation.grand_total, 73.8)
self.assertEqual(quotation.rounding_adjustment, 0.2)
self.assertEqual(quotation.rounded_total, 74)

quotation.disable_rounded_total = 1
quotation.save()

self.assertEqual(quotation.grand_total, 73.8)
self.assertEqual(quotation.rounding_adjustment, 0)
self.assertEqual(quotation.rounded_total, 0)


def enable_calculate_bundle_price(enable=1):
selling_settings = frappe.get_doc("Selling Settings")
Expand Down

0 comments on commit 2ada270

Please sign in to comment.