feat: set scan identifier as first barcode

frappe · May 31, 2022 · bc74a90 · bc74a90
1 parent 29944f3
commit bc74a90
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ecommerce_integrations/unicommerce/product.py b/ecommerce_integrations/unicommerce/product.py
@@ -271,6 +271,9 @@ def _build_unicommerce_item(item_code: ItemCode) -> JsonDict:
 	item_json["enabled"] = not bool(item.get("disabled"))
 
 	for barcode in item.barcodes:
+		if not item_json.get("scanIdentifier"):
+			# Set first barcode as scan identifier
+			item_json["scanIdentifier"] = barcode.barcode
 		if barcode.barcode_type == "EAN":
 			item_json["ean"] = barcode.barcode
 		elif barcode.barcode_type == "UPC-A":

diff --git a/ecommerce_integrations/unicommerce/tests/fixtures/simple_item.json b/ecommerce_integrations/unicommerce/tests/fixtures/simple_item.json
@@ -10,7 +10,7 @@
 		"categoryCode": "Products",
 		"name": "TITANIUM WATCH",
 		"description": "This is a watch.",
-		"scanIdentifier": "TITANIUM_WATCH",
+		"scanIdentifier": "73513537",
 		"length": 100,
 		"width": 100,
 		"height": 50,