Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix import error pitfall for maturin #62

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

frank1010111
Copy link
Owner

@frank1010111 frank1010111 commented Oct 5, 2023

Description

This is a bugfix

It fixes PyO3/maturin#490 by using the recommended layout for mixed rust/python projects

Pull request checklist

  • If features have changed, there's new documentation, and it has been checked: nox -s docs -- serve
  • If a bugfix, new tests are in testing/
  • Passes all CI/CD tests:
    • Pre-commit linting passes: nox -s lint
    • Package builds nox -s build
    • Tests all pass: nox -s tests

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #62 (139893e) into master (7348d2a) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   99.41%   98.82%   -0.59%     
==========================================
  Files           3        3              
  Lines         339      339              
  Branches       67       67              
==========================================
- Hits          337      335       -2     
- Misses          1        2       +1     
- Partials        1        2       +1     
Files Coverage Δ
python/pywaterflood/__init__.py 100.00% <ø> (ø)
python/pywaterflood/crm.py 98.60% <100.00%> (ø)
python/pywaterflood/multiwellproductivity.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frank1010111 frank1010111 merged commit 6797059 into master Oct 5, 2023
15 of 16 checks passed
@frank1010111 frank1010111 deleted the bugfix/import-error-pitfall branch October 5, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing mixed Rust/Python project fails when structured as recommended
1 participant