fix busybox compatibility #137
Open
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelina Hołub <[email protected]> fix: awk busybox compat Signed-off-by: Marcelina Hołub <[email protected]>
| # awk is used instead of ps with -o ppid= because the latter is not | ||
| # supported by busybox | ||
| set tmux_fish_ppid (awk '/PPid:/ {print $2}' /proc/$tmux_fish_pid/status) | ||
| set tmux_fish_ppid_cmd_full (busybox ps | awk "{if (\$1 == $tmux_fish_ppid) print \$NF}") |
There was a problem hiding this comment.
@154pinkchairs you are using busybox in this line, but as far as I understand it is not available in every system. What's the idea?
There was a problem hiding this comment.
hmm yup, my idea was just to have the script work with both, must've missed it
There was a problem hiding this comment.
Would you like to work on alternative? The existing function is error prone and I will have to choose one of the proposed options. This doesn't sound bad if it also covers the other edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
albeit this approach is more verbose, this allowed me to use this plugin under Alpine and shouldn't break coreutils systems either