Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate SQLite as an Offline Store for Feast #7

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link

Integrate SQLite as an Offline Store for Feast

This pull request introduces SQLite as a new offline store option for Feast. The following changes have been made:

  • Added a new SQLiteOfflineStore class in sdk/python/feast/infra/offline_stores/sqlite.py.
  • Implemented CRUD operations for the SQLite offline store.
  • Ensured proper error handling and connection management.
  • Updated unit tests to cover the new functionality in sdk/python/tests/integration/registration/test_universal_types.py.

This integration allows Feast users to utilize SQLite as a lightweight and easy-to-setup offline store for feature storage and retrieval.

Changes Made

  • Created SQLiteOfflineStore class implementing the OfflineStore interface.
  • Implemented methods for reading, writing, and retrieving data from SQLite.
  • Added error handling and connection management using context managers.
  • Ensured compatibility with existing Feast interfaces and data structures.
  • Added a unit test for get_historical_features using the SQLite implementation.

Testing

  • Added new unit test specific to the SQLite integration in test_universal_types.py.

Next Steps

  • Consider adding more comprehensive integration tests for SQLite.
  • Update documentation to include SQLite as an offline store option.
  • Explore performance optimizations for large datasets.

Link to Devin run: https://preview.devin.ai/devin/7cef0302e9854874b881f29528c6b0d6

This Devin run was requested by Francisco Javier

tokoko and others added 11 commits August 6, 2024 09:13
* fix: revert java testcontainers to use docker-based compose

Signed-off-by: tokoko <[email protected]>

* fix: update testcontainers-java to Compose v2

Signed-off-by: tokoko <[email protected]>

---------

Signed-off-by: tokoko <[email protected]>
Co-authored-by: tokoko <[email protected]>
…4366)

feat: instrument feature store

This commit adds opentelemetry to monitor Feast

Signed-off-by: Twinkll Sisodia <[email protected]>
* docs: Adding some content about the push vs pull model

Signed-off-by: Francisco Javier Arceo <[email protected]>

* feat: Updating SQLite-Vec to stable release version:

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing push model changes from other branch

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
* docs: Adding some content about the push vs pull model

Signed-off-by: Francisco Javier Arceo <[email protected]>

* checking in progress...all of this was mostly autogenerated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updated

Signed-off-by: Francisco Javier Arceo <[email protected]>

* Update push-vs-pull-model.md

* Update push-vs-pull-model.md

* Update push-vs-pull-model.md

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
… annotation (feast-dev#4391)

fix: Using get_type_hints instead of inspect for udf return type

Signed-off-by: Bhargav Dodla <[email protected]>
Co-authored-by: Bhargav Dodla <[email protected]>
* Apply fix

Signed-off-by: Job Almekinders <[email protected]>

* Add special characters to postgres online store test

Signed-off-by: Job Almekinders <[email protected]>

* Fix linting error

Signed-off-by: Job Almekinders <[email protected]>

---------

Signed-off-by: Job Almekinders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants