Fix formatValueByTokenType function (#1095)

frakt-solana · Dec 9, 2024 · a56a63f · a56a63f
1 parent 507406e
commit a56a63f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...agePage/LeveragePositionsContent/components/LeveragePositionCard/LeveragePositionCard.tsx b/...agePage/LeveragePositionsContent/components/LeveragePositionCard/LeveragePositionCard.tsx
@@ -132,7 +132,7 @@ const PositionAdditionalInfo: FC<{ loan: TokenLoan }> = ({ loan }) => {
         label="PNL"
         value={
           <span>
-            {isNegativePnl ? '-' : '+'}
+            {isNegativePnl ? '' : '+'}
             <DisplayValue
               strictTokenType={loan.bondTradeTransaction.lendingToken}
               value={loanPnl}

diff --git a/src/utils/tokens/helpers.ts b/src/utils/tokens/helpers.ts
@@ -15,7 +15,7 @@ import {
   TokenUnit,
 } from './constants'
 
-const isValueBelowThreshold = (value: number, threshold: number) => value < threshold
+const isValueBelowThreshold = (value: number, threshold: number) => Math.abs(value) < threshold
 
 export const convertToHumanNumber = (value: number, tokenType: LendingTokenType): number => {
   const decimals = TOKEN_DECIMALS[tokenType]
@@ -27,8 +27,11 @@ export const formatValueByTokenType = (value: number, tokenType: LendingTokenTyp
 
   const convertedValue = convertToHumanNumber(value, tokenType)
 
+  const isNumberNegative = convertedValue < 0
+
   if (isValueBelowThreshold(convertedValue, MIN_VALUE_TO_DISPLAY[tokenType])) {
-    return `<${MIN_VALUE_TO_DISPLAY[tokenType]}`
+    //? Use MIN_VALUE_TO_DISPLAY for negative numbers
+    return `<${isNumberNegative ? '-' : ''}${MIN_VALUE_TO_DISPLAY[tokenType]}`
   }
 
   return formatTokenValue(convertedValue, tokenType)