Make Balance not transferable (#4)

Make Balance not transferable
fragnova · Sep 12, 2022 · 1b6228d · 1b6228d
1 parent 24c700f
commit 1b6228d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/frame/balances/src/lib.rs b/frame/balances/src/lib.rs
@@ -239,6 +239,8 @@ pub mod pallet {
 
 		/// The id type for named reserves.
 		type ReserveIdentifier: Parameter + Member + MaxEncodedLen + Ord + Copy;
+
+		type IsTransferable: Get<bool>;
 	}
 
 	#[pallet::pallet]
@@ -485,6 +487,8 @@ pub mod pallet {
 		DeadAccount,
 		/// Number of named reserves exceed MaxReserves
 		TooManyReserves,
+		/// Whether transfer function is allowed or not
+		CannotTransfer,
 	}
 
 	/// The total units issued in the system.
@@ -1472,13 +1476,16 @@ where
 	}
 
 	// Transfer some free balance from `transactor` to `dest`, respecting existence requirements.
-	// Is a no-op if value to be transferred is zero or the `transactor` is the same as `dest`.
+	// Is a no-op if value to be transferred is zero or the `transactor` is the same as `dest` or the 
+	// transferability set in config is forbidden.
 	fn transfer(
 		transactor: &T::AccountId,
 		dest: &T::AccountId,
 		value: Self::Balance,
 		existence_requirement: ExistenceRequirement,
 	) -> DispatchResult {
+		ensure!(T::IsTransferable::get(), Error::<T, I>::CannotTransfer);
+
 		if value.is_zero() || transactor == dest {
 			return Ok(())
 		}

diff --git a/frame/balances/src/tests_composite.rs b/frame/balances/src/tests_composite.rs
@@ -48,6 +48,7 @@ parameter_types! {
 	pub BlockWeights: frame_system::limits::BlockWeights =
 		frame_system::limits::BlockWeights::simple_max(1024);
 	pub static ExistentialDeposit: u64 = 0;
+	pub static IsTransferable: bool = true;
 }
 impl frame_system::Config for Test {
 	type BaseCallFilter = frame_support::traits::Everything;
@@ -95,6 +96,7 @@ impl Config for Test {
 	type MaxReserves = ConstU32<2>;
 	type ReserveIdentifier = [u8; 8];
 	type WeightInfo = ();
+	type IsTransferable = IsTransferable;
 }
 
 pub struct ExtBuilder {

diff --git a/frame/balances/src/tests_local.rs b/frame/balances/src/tests_local.rs
@@ -49,6 +49,7 @@ parameter_types! {
 	pub BlockWeights: frame_system::limits::BlockWeights =
 		frame_system::limits::BlockWeights::simple_max(1024);
 	pub static ExistentialDeposit: u64 = 0;
+	pub static IsTransferable: bool = true;
 }
 impl frame_system::Config for Test {
 	type BaseCallFilter = frame_support::traits::Everything;
@@ -97,6 +98,7 @@ impl Config for Test {
 	type MaxReserves = ConstU32<2>;
 	type ReserveIdentifier = [u8; 8];
 	type WeightInfo = ();
+	type Transferable = IsTransferable;
 }
 
 pub struct ExtBuilder {

diff --git a/frame/balances/src/tests_reentrancy.rs b/frame/balances/src/tests_reentrancy.rs
@@ -53,6 +53,7 @@ parameter_types! {
 	pub BlockWeights: frame_system::limits::BlockWeights =
 		frame_system::limits::BlockWeights::simple_max(1024);
 	pub static ExistentialDeposit: u64 = 0;
+	pub static IsTransferable: bool = true;
 }
 impl frame_system::Config for Test {
 	type BaseCallFilter = frame_support::traits::Everything;
@@ -99,6 +100,7 @@ impl Config for Test {
 	type MaxReserves = ConstU32<2>;
 	type ReserveIdentifier = [u8; 8];
 	type WeightInfo = ();
+	type IsTransferable = IsTransferable;
 }
 
 pub struct ExtBuilder {