Align with new `set-group` endpoint #753

ychiucco · 2024-11-26T08:59:11Z

closes #752

Checklist before merging

I added an appropriate entry to CHANGELOG.md

github-actions · 2024-11-26T09:03:12Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_client
parser.py	$This PR adds 3 to the number of statements in fractal_client/parser.py, taking it from 202 to 205.$	$This PR doesn't change the number of statements missing coverage in fractal_client/parser.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/parser.py, which is 100% (205/205).$	$In this PR, 3 new statements are added to fractal_client/parser.py, 3 of which are covered (100%).$
fractal_client/cmd
__init__.py	$This PR adds 5 to the number of statements in fractal_client/cmd/__init__.py, taking it from 238 to 243.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/__init__.py, which is 3.$	$This PR adds 0.03 percentage points to the coverage rate in fractal_client/cmd/__init__.py, taking it from 98.75% (235/238) to 98.77% (240/243).$	$In this PR, 5 new statements are added to fractal_client/cmd/__init__.py, 5 of which are covered (100%).$
_user.py	$This PR adds 4 to the number of statements in fractal_client/cmd/_user.py, taking it from 120 to 124.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_user.py, which is 0.$	$This PR adds 0.01 percentage points to the coverage rate in fractal_client/cmd/_user.py, taking it from 99.42% (120/120) to 99.43% (124/124).$	$In this PR, 4 new statements are added to fractal_client/cmd/_user.py, 4 of which are covered (100%).$
Project Total

_{This report was generated by python-coverage-comment-action}

[skip ci]

tests/test_group.py

…set-groups-endpoint' into 752-align-with-new-set-groups-endpoint

fractal-server 2.9.0a11

f71db35

ychiucco linked an issue Nov 26, 2024 that may be closed by this pull request

Align with new set-groups endpoint #752

Closed

ychiucco added 4 commits November 26, 2024 10:25

new command

346e691

remove required

3812de5

test

b280fa5

changelog

6dd1e81

[skip ci]

ychiucco requested a review from tcompa November 26, 2024 10:01

ychiucco and others added 3 commits November 26, 2024 11:23

fix bugged test

d821d38

Update parser.py help messages

8afaff6

Update parser.py - fix string

b94ef19

tcompa reviewed Nov 26, 2024

View reviewed changes

tests/test_group.py Outdated Show resolved Hide resolved

ychiucco added 2 commits November 27, 2024 09:03

do not rely on server ordering in tests

a541511

Merge remote-tracking branch 'refs/remotes/origin/752-align-with-new-…

33ec651

…set-groups-endpoint' into 752-align-with-new-set-groups-endpoint

ychiucco merged commit 2099f4a into main Nov 27, 2024
10 checks passed

ychiucco deleted the 752-align-with-new-set-groups-endpoint branch November 27, 2024 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align with new `set-group` endpoint #753

Align with new `set-group` endpoint #753

ychiucco commented Nov 26, 2024 •

edited by tcompa

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

Align with new set-group endpoint #753

Align with new set-group endpoint #753

Conversation

ychiucco commented Nov 26, 2024 • edited by tcompa Loading

Checklist before merging

github-actions bot commented Nov 26, 2024 • edited Loading

Coverage report

Align with new `set-group` endpoint #753

Align with new `set-group` endpoint #753

ychiucco commented Nov 26, 2024 •

edited by tcompa

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading