Write union types as `X | Y` #731

ychiucco · 2024-11-04T13:39:54Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md

github-actions · 2024-11-04T13:42:56Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_client
client.py	$This PR removes 1 from the number of statements in fractal_client/client.py, taking it from 58 to 57.$	$This PR doesn't change the number of statements missing coverage in fractal_client/client.py, which is 4.$	$This PR removes 0.10 percentage points from the coverage rate in fractal_client/client.py, taking it from 92.85% (54/58) to 92.75% (53/57).$	$This PR does not seem to add statements to fractal_client/client.py.$
config.py	$This PR removes 1 from the number of statements in fractal_client/config.py, taking it from 15 to 14.$	$This PR doesn't change the number of statements missing coverage in fractal_client/config.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/config.py, which is 100% (14/14).$	$In this PR, 2 new statements are added to fractal_client/config.py, 2 of which are covered (100%).$
response.py	$This PR removes 1 from the number of statements in fractal_client/response.py, taking it from 38 to 37.$	$This PR doesn't change the number of statements missing coverage in fractal_client/response.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/response.py, which is 100% (37/37).$	$This PR does not seem to add statements to fractal_client/response.py.$
fractal_client/cmd
_aux_task_caching.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_aux_task_caching.py, taking it from 84 to 83.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_aux_task_caching.py, which is 1.$	$This PR removes 0.02 percentage points from the coverage rate in fractal_client/cmd/_aux_task_caching.py, taking it from 98.07% (83/84) to 98.05% (82/83).$	$This PR does not seem to add statements to fractal_client/cmd/_aux_task_caching.py.$
_dataset.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_dataset.py, taking it from 35 to 34.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_dataset.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/cmd/_dataset.py, which is 100% (34/34).$	$This PR does not seem to add statements to fractal_client/cmd/_dataset.py.$
_group.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_group.py, taking it from 34 to 33.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/cmd/_group.py, which is 100% (33/33).$	$This PR does not seem to add statements to fractal_client/cmd/_group.py.$
_job.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_job.py, taking it from 67 to 66.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_job.py, which is 8.$	$This PR removes 0.17 percentage points from the coverage rate in fractal_client/cmd/_job.py, taking it from 85.88% (59/67) to 85.71% (58/66).$	$This PR does not seem to add statements to fractal_client/cmd/_job.py.$
_project.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_project.py, taking it from 31 to 30.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_project.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_client/cmd/_project.py, which is 100% (30/30).$	$This PR does not seem to add statements to fractal_client/cmd/_project.py.$
_task.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_task.py, taking it from 114 to 113.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_task.py, which is 2.$	$This PR removes 0.01 percentage points from the coverage rate in fractal_client/cmd/_task.py, taking it from 98.21% (112/114) to 98.2% (111/113).$	$This PR does not seem to add statements to fractal_client/cmd/_task.py.$
_user.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_user.py, taking it from 117 to 116.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_user.py, which is 0.$	$This PR removes 0.00 percentage points from the coverage rate in fractal_client/cmd/_user.py, taking it from 99.4% (117/117) to 99.39% (116/116).$	$This PR does not seem to add statements to fractal_client/cmd/_user.py.$
_workflow.py	$This PR removes 1 from the number of statements in fractal_client/cmd/_workflow.py, taking it from 121 to 120.$	$This PR doesn't change the number of statements missing coverage in fractal_client/cmd/_workflow.py, which is 1.$	$This PR removes 0.01 percentage points from the coverage rate in fractal_client/cmd/_workflow.py, taking it from 98.72% (120/121) to 98.71% (119/120).$	$This PR does not seem to add statements to fractal_client/cmd/_workflow.py.$
Project Total

_{This report was generated by python-coverage-comment-action}

ychiucco added 2 commits November 4, 2024 14:09

Union[X, Y] to X | Y

351c230

Optional[X] to X | None

1e4f012

tcompa merged commit f2384d0 into main Nov 4, 2024
10 checks passed

tcompa deleted the union-types branch November 4, 2024 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write union types as `X | Y` #731

Write union types as `X | Y` #731

ychiucco commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

Write union types as X | Y #731

Write union types as X | Y #731

Conversation

ychiucco commented Nov 4, 2024

Checklist before merging

github-actions bot commented Nov 4, 2024

Coverage report

Write union types as `X | Y` #731

Write union types as `X | Y` #731