Skip to content

Commit

Permalink
sql/schmachanger: use more friendly language for fallback
Browse files Browse the repository at this point in the history
Previously, the declarative schema changer used slightly
alarming language when falling back. To address this,
this patch removes the word failure and uses softer
langauge.

Fixes: cockroachdb#97922

Release note: None
  • Loading branch information
fqazi committed Mar 7, 2023
1 parent 71d8239 commit 49192c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/sql/schemachanger/scerrors/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (el EventLogger) HandlePanicAndLogError(ctx context.Context, err *error) {
log.InfofDepth(ctx, depth, "done %s in %s", el.msg, redact.Safe(timeutil.Since(el.start)))
}
case HasNotImplemented(*err):
log.InfofDepth(ctx, depth, "failed %s with error: %v", el.msg, *err)
log.InfofDepth(ctx, depth, "unsuccessful in %s with message: %v", el.msg, *err)
case errors.HasAssertionFailure(*err):
*err = errors.Wrapf(*err, "%s", el.msg)
fallthrough
Expand Down

0 comments on commit 49192c1

Please sign in to comment.