-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"no implicit conversion of URI::HTTPS into String" exception after upgrading to 1.12.0 #280
Comments
Hello there 👋 Any news about this issue ? Many thanks in advance for your help ! |
I'm the sole owner of this. I'll get to it eventually. Thanks for your patience 😊 |
@lauratpa's PR looks fine to me. What would be the hold up on just merging it? If it's lack of tests, please let me know and I can work on adding them |
After upgrading to 1.12.0 our code started to fail with:
We are using ruby 2.7, so it seems that this change https://github.com/fphilipe/premailer-rails/pull/261/files
now triggers the exception, since Net::HTTP for ruby 2.7 does not support headers.
The text was updated successfully, but these errors were encountered: