Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't iter evicted entries with noop disk cache #834

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jan 10, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

This PR bypass the iteration with noop disk cache.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#830

@MrCroxx MrCroxx self-assigned this Jan 10, 2025
@MrCroxx MrCroxx changed the title feat: don't iter evicted entries with noop disk cache perf: don't iter evicted entries with noop disk cache Jan 10, 2025
@MrCroxx MrCroxx added refactor perf Performance optimization labels Jan 10, 2025
@MrCroxx MrCroxx added this to the v0.14 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/cache.rs 57.14% 3 Missing ⚠️
foyer-memory/src/raw.rs 81.81% 2 Missing ⚠️
foyer-memory/src/pipe.rs 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/store.rs 86.63% <100.00%> (+0.09%) ⬆️
foyer/src/hybrid/builder.rs 93.61% <100.00%> (-0.45%) ⬇️
foyer/src/hybrid/cache.rs 82.89% <100.00%> (ø)
foyer-memory/src/pipe.rs 89.23% <85.71%> (-0.43%) ⬇️
foyer-memory/src/raw.rs 88.96% <81.81%> (+0.50%) ⬆️
foyer-memory/src/cache.rs 78.51% <57.14%> (-0.90%) ⬇️

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit bdf4846 into main Jan 10, 2025
27 checks passed
@MrCroxx MrCroxx deleted the xx/noop branch January 10, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant