Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no option for enabling proxy by pattern #49

Closed
rezatorabi opened this issue Nov 12, 2019 · 4 comments
Closed

There is no option for enabling proxy by pattern #49

rezatorabi opened this issue Nov 12, 2019 · 4 comments

Comments

@rezatorabi
Copy link

The options "Use Enabled Proxies By Pattern and Priority" or "ignore patterns" don't exist for me.
This is how I think it is supposed to be:
options

And this is what I have:
foxyproxy

I am using FoxyProxy Standard version 7.4.1 in Firefox 70.0.1 on Ubuntu 18.04.

@rezatorabi rezatorabi changed the title There ise no option for enabling proxy by pattern There is no option for enabling proxy by pattern Nov 12, 2019
@ericjung
Copy link
Collaborator

Hi

This happens when you don't have any whitelist patterns defined. It is confusing and I will remove it in the next release. The idea is that without whitelist patterns, there is no reason to put FoxyProxy into patterns mode... No URLs will ever match.

Anyway, for now, please add a whitelist pattern (even just *) and you'll see that option.

@rezatorabi
Copy link
Author

Hi,
Thanks for the fast response. It is working now.

Maybe it would be more straightforward if the "* whitelist pattern" existed by default. (It is usually how the user expects it to be that if he doesn't define any whitelist pattern and only defines blacklist pattern, he wants it so that everything except the defined blacklist are proxied and if he only defines whitelist pattern and no blacklist pattern I want nothing to be proxied except the defined whitelist). I think using whitelists and blacklists at the same time doesn't make much sense to me and is not a common usecase.

@ericjung
Copy link
Collaborator

Maybe it would be more straightforward if the "* whitelist pattern" existed by default.

Agreed. When adding a new proxy, Add whitelist pattern to match all URLs should be ON by default. Currently it is OFF by default. I will change this.

fp-999

@rezatorabi
Copy link
Author

That would be great.

Thanks a lot for maintaining this useful add-on.

ericjung added a commit that referenced this issue Nov 16, 2019
… URLs</strong> is now on by default. Discussed <a href="#49" target="_blank">here</a>.

* On patterns window, added button for <strong>Add whitelist pattern to match all URLs</strong> similar to the existing button <strong>Add black patterns to prevent this proxy being used for localhost & intranet/private IP addresses</strong>.
* Patterns Cheat Sheet improvements &mdash; more examples and text explaining that blacklist patterns take precedence over whitelist patterns.
* Change an i18n key name so it works in chrome, too (chrome does not allow periods in key names).
* Remove unneeded console log messages.
* Faster deletion of patterns (faster animation)
ericjung added a commit that referenced this issue Nov 16, 2019
…Ls that didn't match anything are now in their own section.

* Patterns mode now exists even if there are no white patterns defined. This was the behavior of FoxyProxy before 7.x. Its absence when no white patterns
  are defined makes sense (no proxy will ever be used), but has been a source of tremendous confusion. Discussed here: #49
but also many other places.
@ericjung ericjung mentioned this issue Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants