Remove gendeps2 utility #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defunctzombie
deleted the
roman/fg-6257-docmentation-for-running-gendeps2-foxgloverosmsg-44
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a packaging issue making it appear that "gendeps2" was an executable built and available for installs of the package. This utility was not automatically packaged or available making the "bin" entry in package.json misleading.
I prefer to separate utilities/CLI tools from library packages and
@foxglove/rosmsgis a library. I have removed the gendeps2 file and incompletebinfile. We are not using this utility and ROS provides this via a python package and to avoid misleading users that we will support this file.Fixes: #44