Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support include as a field name #166

Merged

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented May 13, 2024

Changelog

support include as a field name

Docs

None

Description

We were treating include as a keyword in our nearly grammar even though it is not considered a keyword in the OMGIDL spec. This PR fixes this which allows to use include as a regular field name.

@achim-k achim-k requested a review from snosenzo May 13, 2024 14:50
Copy link

linear bot commented May 13, 2024

@jtbandes
Copy link
Member

@snosenzo any idea if there was a reason we purposely treated include as a keyword before?

@achim-k achim-k merged commit 8c870c3 into main May 14, 2024
2 checks passed
@achim-k achim-k deleted the achim/fg-7473-omgidl-support-include-as-a-variable-name branch May 14, 2024 12:22
achim-k added a commit that referenced this pull request May 14, 2024
### update `omgidl-parser` package minor version (v1.0.4 -> v1.0.5). 

Changes:
 - suppot `include` as field name (#166)
 - support empty structs (#167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants