Add blksize, nblocks, and birthtime_ns to stat for FFS #917
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
+ Coverage 76.84% 76.88% +0.04%
==========================================
Files 322 322
Lines 27405 27408 +3
==========================================
+ Hits 21060 21074 +14
+ Misses 6345 6334 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @pytest.fixture | ||
| def ffs_fs() -> Iterator[FfsFilesystem]: |
There was a problem hiding this comment.
I would place this fixture in the conftest.py file, rename it to fs_ffs and place it at the other fs_* fixtures there
There was a problem hiding this comment.
I wouldn't, it's only used here.
There was a problem hiding this comment.
@Poeloe The ffs_fs fixture is only used in this test file, so I agree with Schamper that it makes more sense to not expose them in the conftest.py file . We can always move them if they are needed in other tests.
Is that acceptable?
| @pytest.fixture | ||
| def ffs_fs_entry(ffs_fs: FfsFilesystem) -> Iterator[FfsFilesystemEntry]: |
There was a problem hiding this comment.
Maybe just also place this fixture in the conftest.py, but I'll leave that up to you 😄
On Linux, stat always returns the default block size of 4096
We are returning the actual block size of the filesystem, similar to stat on BSD
Note: st_blocks * 512 can be lower than st_blksize because FFS employs fragments
Closes #818