Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with cstruct v4 #37

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Compatibility with cstruct v4 #37

merged 2 commits into from
Jun 4, 2024

Conversation

Schamper
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (b28a604) to head (97eee02).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   79.10%   79.08%   -0.02%     
==========================================
  Files          15       15              
  Lines        1273     1272       -1     
==========================================
- Hits         1007     1006       -1     
  Misses        266      266              
Flag Coverage Δ
unittests 79.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyrco
pyrco previously approved these changes May 24, 2024
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No cleanup of the loading of c_esedb in c_esedb.py?

pyrco
pyrco previously approved these changes May 24, 2024
@Schamper
Copy link
Member Author

No cleanup of the loading of c_esedb in c_esedb.py?

Oversight, fixed it.

pyrco
pyrco previously approved these changes May 24, 2024
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@pyrco pyrco merged commit 69b296e into main Jun 4, 2024
17 of 18 checks passed
@pyrco pyrco deleted the cstruct-v4 branch June 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants