Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Terraform SDK provider 2.4.1 #31

Merged
merged 6 commits into from
Sep 11, 2022

Conversation

daniel-noland
Copy link
Contributor

Simple bump to neweset Terraform SDK provider.
This was a major SDK version bump but only minor changes were required.
Specifically, the SDK provider removed the helper/hashcode package
Based on my desire for MVP changes to accomplish this upgrade I went along with the advice detailed in the above link and simply used trivially modified versions of the public domain functions provided in that link.

As far as I can tell, this project does not strictly require the hash function to behave exactly this way.
However, the minimal change should make bisection easier if the version bump causes regressions.

@daniel-noland
Copy link
Contributor Author

Just as a note, this is my first swing at Go as a language so please let me know if I messed up any conventions or you would like to see any modifications.

As I am not especially familiar with this project I don't know if these changes are desirable for your use case nor how to best do integration testing on this change set.
Thus I have left this as a draft PR for the moment.

Daniel Noland added 2 commits January 24, 2021 11:35
Simple bump to neweset Terraform SDK provider.
This was a major SDK version bump but only minor changes were required.
Specifically, the SDK provider [removed the `helper/hashcode`
package](https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#removal-of-helper-hashcode-package)
Based on my desire for MVP changes to accomplish this upgrade I went
along with the advice detailed in the above link and simply used
trivially modified versions of the public domain functions provided in
that link.

As far as I can tell, this project does not strictly require the hash
function to behave exactly this way.
However, the minimal change should make bisection easier if the version
bump causes regressions.
I don't understand why upgrading the terraform SDK triggered typing
changes (seemingly related to go-jira which I did not change).
At any rate, this patch is an attempt to resolve those problems.
Please let me know if this fix is unrelated to the SDK update and I will
make a new PR (or else fix whatever mistake I made which triggered these
typing problems).
@daniel-noland
Copy link
Contributor Author

I do not understand exactly why the second patch in this series is necessary as I do not think I did anything to go-jira which should have provoked those type issues.
Thus, I left these as separate patches in the series.

That said, I am happy to squash these together if those changes make sense.

Upgrading this from draft as I think the change set can be meaningfully reviewed now.

@daniel-noland daniel-noland marked this pull request as ready for review January 24, 2021 20:06
@fourplusone
Copy link
Owner

Hi Daniel

Thanks a lot for your PR. The SDK update looks very good to me. However I'd like to take a closer look on the changed types for category & lead in order to make sure not to break anything. Can you tell my against which Version of JIRA you tested your changes?

@daniel-noland
Copy link
Contributor Author

That makes sense, I was a little confused myself.
The (partially redacted) response from my Jira version query:

from

rest/api/2/serverInfo

I get

{
  "version": "1001.0.0-SNAPSHOT",
  "versionNumbers": [
    1001,
    0,
    0
  ],
  "buildDate": "2021-01-24T13:25:17.000-0700",
  "scmInfo": "4dba4bbac82b4ed6e51419a8be618b7db816b071",
  "deploymentType": "Cloud",
  "buildNumber": 100154
}

Let me know if I can help with testing. I don't have a non-production Jira environment to test against however.

@ghost
Copy link

ghost commented Jun 8, 2021

+1 on this PR - HashiCorp EOL'd v1 of their SDK effective July 31: https://discuss.hashicorp.com/t/end-of-life-timeline-for-v1-of-the-terraform-plugin-sdk/24991

@fourplusone
Copy link
Owner

Thanks for the heads up. I’ll have a look soon.

@fourplusone fourplusone merged commit 816c8e9 into fourplusone:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants