Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#893] Add summoning to item activation workflow #3167

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Mar 1, 2024

Adds summoning configuration to the item usage configuration and the ability use dialog. Players will see a checkbox to indicate whether summoning should occur and if the item has more than one summoning profile, a dropdown for selecting which profile to use:

Summoning Ability Use Dialog

This also introduces a prompt boolean similar to the one used for measured templates and limited uses to control whether it is done by default or not. If the "Place Summons" checkbox is checked, then the selected summoning profile ID is stored in flags in the chat message.

A new "Summon" button has been added to the chat message to perform the summoning if not done automatically through the ability use process:

Summoning Chat Card

If the button is clicked it will try to summon whatever profile is specified in the flags, or if none is specified it will throw up the ability use dialog again to ask which should be used.

@arbron arbron added epic feature request in progress ux User experience related features or bugs labels Mar 1, 2024
@arbron arbron added this to the D&D5E 3.1.0 milestone Mar 1, 2024
@arbron arbron requested a review from Fyorl March 1, 2024 19:32
@arbron arbron self-assigned this Mar 1, 2024
@arbron arbron force-pushed the summoning-prompt branch from e248887 to 37e979c Compare March 1, 2024 21:15
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one comment for discussion, let me know what you think.

module/documents/item.mjs Outdated Show resolved Hide resolved
@arbron arbron merged commit 22f407a into 3.1.x Mar 6, 2024
@arbron arbron deleted the summoning-prompt branch March 6, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants