Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading data from files #445

Merged
merged 23 commits into from
Aug 16, 2023
Merged

Loading data from files #445

merged 23 commits into from
Aug 16, 2023

Conversation

piotmag769
Copy link
Member

@piotmag769 piotmag769 commented Aug 9, 2023

Introduced changes

  • Added code to snforge_std that allows reading data from txt files

Breaking changes

  • Cwd is set to directory Scarb.toml resides in when executing tests for a package (if executed for workspace, cwd changes for every package)

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

Decided to postpone implementation of loading data from json #457
Docs will be in separate PR #458

@piotmag769 piotmag769 linked an issue Aug 9, 2023 that may be closed by this pull request
@piotmag769 piotmag769 marked this pull request as ready for review August 10, 2023 18:41
@piotmag769 piotmag769 requested review from a team August 10, 2023 18:41
@piotmag769 piotmag769 requested a review from a team as a code owner August 10, 2023 18:41
@piotmag769 piotmag769 requested review from Arcticae, abulenok, tkumor3, cptartur and THenry14 and removed request for a team August 10, 2023 18:41
@piotmag769 piotmag769 requested a review from war-in August 10, 2023 18:41
@piotmag769 piotmag769 requested review from bartekryba and removed request for cptartur August 10, 2023 18:42
@piotmag769 piotmag769 requested a review from war-in August 16, 2023 08:08
@piotmag769 piotmag769 enabled auto-merge August 16, 2023 14:58
## Checklist

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Marcin Warchoł <[email protected]>
@piotmag769 piotmag769 added this pull request to the merge queue Aug 16, 2023
Merged via the queue into master with commit 1a6bddc Aug 16, 2023
@piotmag769 piotmag769 deleted the 242-loading-test-data-from-files branch August 16, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading test data from files
4 participants