Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precalculate contract address function #433

Merged
merged 31 commits into from
Aug 17, 2023
Merged

Precalculate contract address function #433

merged 31 commits into from
Aug 17, 2023

Conversation

tkumor3
Copy link
Contributor

@tkumor3 tkumor3 commented Aug 8, 2023 •
edited
Loading

Closes #

Introduced changes

Breaking changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@tkumor3 tkumor3 linked an issue Aug 8, 2023 that may be closed by this pull request
Support for precalculating contract address before deploy #395
Closed
1 task
piotmag769
piotmag769 reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove PrepraredContract now too

benchmarks/data/forge.cairo Outdated Show resolved Hide resolved
cheatcodes/src/cheatcodes.cairo Outdated Show resolved Hide resolved
@tkumor3 tkumor3 marked this pull request as ready for review August 10, 2023 11:15
@tkumor3 tkumor3 requested a review from a team August 10, 2023 11:15
@tkumor3 tkumor3 requested a review from a team as a code owner August 10, 2023 11:15
@tkumor3 tkumor3 requested review from a team, bartekryba, piotmag769, THenry14, war-in, Arcticae and Radinyn and removed request for a team August 10, 2023 11:15
@piotmag769 piotmag769 changed the title change how works cheatcode declare and deploy + fix tests Precalculate contract address function Aug 10, 2023
piotmag769
piotmag769 reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please update CHANGELOD.md and make sure to rebase to master branch after #419 is merged (blockifier operations and writing to memory got separated)

crates/forge/tests/data/simple_package/tests/ext_function_test.cairo Outdated Show resolved Hide resolved
crates/forge/tests/data/simple_package/tests/ext_function_test.cairo Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/deploy.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/deploy.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/lib.rs Outdated Show resolved Hide resolved
war-in
war-in reviewed Aug 10, 2023
View reviewed changes
cheatcodes/src/cheatcodes.cairo Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/deploy.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/deploy.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/forge/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to get rid of PreparedContract

crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/forge/tests/integration/precalculate_address.rs Outdated Show resolved Hide resolved
crates/forge/tests/integration/precalculate_address.rs Show resolved Hide resolved
crates/forge/tests/integration/precalculate_address.rs Outdated Show resolved Hide resolved
crates/forge/tests/integration/precalculate_address.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

benchmarks/data/forge.cairo Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/cheatable-starknet/src/cheatcodes/precalculate_address.rs Outdated Show resolved Hide resolved
crates/forge/tests/data/contracts/constructor_simple.cairo Outdated Show resolved Hide resolved
piotmag769
piotmag769 reviewed Aug 16, 2023
View reviewed changes
crates/forge/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/declare.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/precalculate_address.md Show resolved Hide resolved
docs/src/appendix/forge-library/deploy.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/precalculate_address.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/precalculate_address.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/precalculate_address.md Outdated Show resolved Hide resolved
piotmag769
piotmag769 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥 Please refrain from merging before release though 🙏

docs/src/appendix/forge-library/deploy.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/declare.md Outdated Show resolved Hide resolved
docs/src/appendix/forge-library/precalculate_address.md Outdated Show resolved Hide resolved
@tkumor3 tkumor3 linked an issue Aug 17, 2023 that may be closed by this pull request
Finish start_mock_call_when_contract_not_deployed test when precalculate_address will be ready #465
Closed
@piotmag769 piotmag769 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into master with commit c868a82 Aug 17, 2023
6 checks passed
@piotmag769 piotmag769 deleted the 395-support-for-precalculating-contract-address-before-deploy branch August 17, 2023 13:40
@cptartur cptartur mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@war-in war-in war-in left review comments

@piotmag769 piotmag769 piotmag769 approved these changes

@Arcticae Arcticae Arcticae approved these changes

@bartekryba bartekryba Awaiting requested review from bartekryba

@THenry14 THenry14 Awaiting requested review from THenry14 THenry14 was automatically assigned from foundry-rs/starknet-foundry-cast

@Radinyn Radinyn Awaiting requested review from Radinyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tkumor3 @Arcticae @piotmag769 @war-in