Cheatcode for getting hash of the block #2648
Open
+920
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroRosalba
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
kkawula
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Hi @PedroRosalba, unfortunately, your solution isn't proper.
Please study other pr's that introduce cheatcode e.g. #2634 or many other you can find in our repo history.
Your solution should contain:
- cheatcode implementation
- entry in snfoundry_std
- e2e tests (on cairo side)
- documentation
|
Hints for development:
If your tests pass, please submit your PR as ready to review. |
|
hey, can you review for some feedback? unfortunately I could not test the code (my computer even with no other tasks running cannot run cargo test e2e). sorry for the inconvenience. looking forward to continue working on this. sorry again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #684
Introduced changes
Checklist
CHANGELOG.md