fix: modify installation.md file #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
od-hunter
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
kkawula
requested changes
Oct 27, 2024
There was a problem hiding this comment.
I've made some comments, remember that this update should be a short addition to the paragraph that describes installing via asdf, so you do not have to be very verbose.
Suggestion: You can consider creating highlighted field like this one: link code: code
Note: Before requesting a review you can build docs locally and check if everything looks great. mdbook build and mdbook serve will give you this opportunity
Note: Avoid using LLM or ChatGPT to tackle the issues.
cptartur
requested changes
Oct 28, 2024
|
@od-hunter any progress on this? |
cptartur
requested changes
Oct 30, 2024
cptartur
approved these changes
Oct 31, 2024
kkawula
requested changes
Nov 4, 2024
Co-authored-by: kkawula <[email protected]>
kkawula
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2594
Introduced changes
Checklist
CHANGELOG.md