Handle contract redeclaration in cast script #2614
Open
+302
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
force-pushed
the
2469-contract-redeclaration
branch
from
dbf9e0e
to
fdd9840
Compare
This reverts commit fdd9840.
cptartur
force-pushed
the
2469-contract-redeclaration
branch
from
ba8a972
to
a5dfaaf
Compare
cptartur
requested review from
ddoktorski,
kkawula and
franciszekjob
as code owners
franciszekjob
requested changes
Nov 7, 2024
| @@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - You can skip `--name` flag when using `account import` - a default name will be generated. | |||
|
|
|||
| #### Changed | |||
|
|
|||
| - In scripts, changed return type of `declare` so it can handle already declared contracts without failing | |||
There was a problem hiding this comment.
It seems to me that not everyone reading this would know what was meant by scripts. Optionally, we can not include the link.
Suggested change
| - In scripts, changed return type of `declare` so it can handle already declared contracts without failing | |
| - Updated the return type of `declare` in [Cairo Deployment Scripts](https://foundry-rs.github.io/starknet-foundry/starknet/script.html) to handle already declared contracts without failing |
| @@ -237,7 +238,7 @@ async fn test_strk_fee_settings() { | |||
| let contract_dir = duplicate_contract_directory_with_salt( | |||
| SCRIPTS_DIR.to_owned() + "/map_script/contracts/", | |||
| "dummy", | |||
| "100", | |||
| "12345", | |||
| declare_transaction_response | ||
| } | ||
| DeclareResponse::AlreadyDeclared(_) => { | ||
| unreachable!("Argument skip_on_already_declared is false") |
There was a problem hiding this comment.
nit:
Suggested change
| unreachable!("Argument skip_on_already_declared is false") | |
| unreachable!("Argument `skip_on_already_declared` is false") |
|
|
||
| // Check if already declared contract was handled correctly | ||
| match second_declare_result { | ||
| DeclareResult::Success(_) => panic!("Should be already declare"), |
There was a problem hiding this comment.
Suggested change
| DeclareResult::Success(_) => panic!("Should be already declare"), | |
| DeclareResult::Success(_) => panic!("Should be already declared"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2469
Introduced changes
declarein cast scripts so it doesn't fail on already declared contracts.Checklist
CHANGELOG.md