Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error while calling nonexistent entry point selector #2606

Merged
merged 14 commits into from
Nov 4, 2024
Merged

Fix error while calling nonexistent entry point selector #2606

merged 14 commits into from
Nov 4, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Oct 24, 2024 •
edited
Loading

Closes #1812

The Err message chosen to be thrown by safe-dispatcher is intended to replicate cairo-test behavior. These felts are taken explicitly from CairoHintProcessor

Introduced changes

  • Add proper regex to catch falling error message

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula
Copy link
Collaborator Author

kkawula commented Oct 27, 2024

The error message was created specifically to reflect and be in consequence with the cairo-test. Now both tests give the same output: tests

@kkawula kkawula marked this pull request as ready for review October 28, 2024 08:24
@kkawula
Merge branch 'master' into kkawula/1812-different-errors-when-calling…
ea08dcc 
…-unknown-entry-point-selector-error-from-contract-and-from-test
cptartur
cptartur requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that verifies this behavior was fixed?

crates/cheatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/panic_data.rs Show resolved Hide resolved
franciszekjob
franciszekjob approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two places in which we should add comments with reference links, otherwise it's good to go 👌 .

@kkawula kkawula requested a review from cptartur November 4, 2024 07:55
@cptartur cptartur added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit 3d8eb92 Nov 4, 2024
25 checks passed
@cptartur cptartur deleted the kkawula/1812-different-errors-when-calling-unknown-entry-point-selector-error-from-contract-and-from-test branch November 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different errors when calling unknown entry point selector error from contract and from test
3 participants
@kkawula @cptartur @franciszekjob