feat(cast): add support for beacon proxies in cast impl #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xvv
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
0xvv
force-pushed
the
cast-impl-beacons
branch
2 times, most recently
from
23098bb to
1dd8096
Compare
0xvv
force-pushed
the
cast-impl-beacons
branch
from
1dd8096 to
10c26f6
Compare
|
Thanks @0xvv! This looks good |
grandizzy
reviewed
Dec 17, 2024
zerosnacks
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
cast implhas no easy way to read the implementation forBeaconProxylike contractSolution
Add a
--beaconflag tocast implthat changes which storage slot is read to fetch the implementation address.I added cast tests for both cases of
cast implhowever they are both using actively used proxies, if someone has addresses for anEIP1967Proxyand aBeaconProxythat will never be upgraded it would prevent those tests breaking in the future