fix(`cli`): handle id and named chain_id's correctly #9480

yash-atreya · 2024-12-04T06:57:02Z

Motivation

Currently, when inserting the passed chain into figment dict we don't differentiate between ChainKind::Id and ChainKind::NamedChain, even though they hold different types underneath; u64 and String respectively.

Solution

Insert Chain into dict according to Id or NamedChain

grandizzy

Lgtm! Can we add a test with command from ticket?

fix(cli): handle id and named chain_id's correctly

f5acb17

yash-atreya requested review from DaniPopes, klkvr, mattsse, grandizzy and zerosnacks as code owners December 4, 2024 06:57

grandizzy reviewed Dec 4, 2024

View reviewed changes

test

c28ed8f

yash-atreya enabled auto-merge (squash) December 4, 2024 07:22

nit

7274053

mattsse approved these changes Dec 4, 2024

View reviewed changes

yash-atreya merged commit 3a1e76b into master Dec 4, 2024
21 checks passed

yash-atreya deleted the yash/fix-9476 branch December 4, 2024 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(`cli`): handle id and named chain_id's correctly #9480

fix(`cli`): handle id and named chain_id's correctly #9480

yash-atreya commented Dec 4, 2024

grandizzy left a comment

fix(cli): handle id and named chain_id's correctly #9480

fix(cli): handle id and named chain_id's correctly #9480

Conversation

yash-atreya commented Dec 4, 2024

Motivation

Solution

grandizzy left a comment

Choose a reason for hiding this comment

fix(`cli`): handle id and named chain_id's correctly #9480

fix(`cli`): handle id and named chain_id's correctly #9480