Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remappings): project autoremappings should respect config #9466

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #9454
Project paths remappings were automatically added with PR #9258 in order to solve #3440 but used config key instead value:
For src=src/contracts config, remapping should be src/contracts/ = src/contracts/ (instead src=src/contracts)
For src=src config, remapping should be src/ = src/.

Solution

  • add remappings for configured dirs

@grandizzy grandizzy marked this pull request as ready for review December 3, 2024 07:29
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, would like one more review as remappings are sensitive

cc @klkvr / @DaniPopes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@zerosnacks zerosnacks merged commit 25c978a into foundry-rs:master Dec 4, 2024
21 checks passed
@grandizzy grandizzy self-assigned this Dec 9, 2024
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

[POC repo included] default foundry.toml "src" remappings dont work correctly
3 participants