Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): special functions have no name #9441

Merged
merged 6 commits into from
Dec 2, 2024
Merged

fix(coverage): special functions have no name #9441

merged 6 commits into from
Dec 2, 2024

Conversation

DaniPopes
Copy link
Member

fallback, receive, and constructor have an empty name in the AST. Use the kind as the name instead.

@DaniPopes DaniPopes force-pushed the dani/cov-empty-name branch from b7fda34 to 2e65cce Compare December 1, 2024 14:58
grandizzy
grandizzy approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DaniPopes DaniPopes merged commit 168b239 into master Dec 2, 2024
22 checks passed
@DaniPopes DaniPopes deleted the dani/cov-empty-name branch December 2, 2024 05:56
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @grandizzy