Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): account for build_id in source identification #9418

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Ref: #9366 (comment)

Solution

  • Introduces SourceIdentifier which wraps both build_id and source_id.
  • SourceIdentifier replaces source_id as a key identifier for source files in report and analysis.

@zerosnacks zerosnacks self-requested a review November 27, 2024 08:57
@yash-atreya yash-atreya changed the title fix(coverage): account for build_id's in source identification fix(coverage): account for build_id in source identification Nov 27, 2024
@yash-atreya yash-atreya merged commit 7d639e6 into yash/fix-8840 Nov 27, 2024
20 checks passed
@yash-atreya yash-atreya deleted the yash/cov-acc-build-ids branch November 27, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants