Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate gas_limit / block_gas_limit field, declare as alias #9406

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Nov 25, 2024

Motivation

Closes: #4693

Solution

Declared as visible alias for backwards compatibility

Also mirrors

    #[arg(long, visible_alias = "no-gas-limit")]
    pub disable_block_gas_limit: bool,

Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@zerosnacks zerosnacks marked this pull request as ready for review November 25, 2024 14:11
@zerosnacks zerosnacks self-assigned this Nov 25, 2024
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@zerosnacks zerosnacks merged commit de5e89c into master Nov 25, 2024
21 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/fix-gas-limit-block-gas-limit-fields branch November 25, 2024 14:17
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
…as alias (foundry-rs#9406)

remove duplicate gas_limit field, declare as alias
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

The help comments for --gas-limit and --block-gas-limit are the same.
3 participants