feat(cheatcodes): count assertion for expectEmit
#9405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
yash-atreya
changed the title
cheatcodes): count for expectEmit and expectRevert
yash-atreya
changed the title
cheatcodes): count for expectEmit and expectRevert cheatcodes): count for expectEmit
yash-atreya
changed the title
cheatcodes): count for expectEmitcheatcodes): count assertion for expectEmit
zerosnacks
reviewed
Dec 5, 2024
zerosnacks
reviewed
Dec 5, 2024
zerosnacks
reviewed
Dec 5, 2024
grandizzy
requested changes
Dec 6, 2024
|
@zerosnacks @grandizzy please drop your final review |
zerosnacks
approved these changes
Dec 17, 2024
yash-atreya
added a commit
to foundry-rs/forge-std
that referenced
this pull request
Dec 17, 2024
Ref: foundry-rs/foundry#9405 Adds the following cheatcodes to the interface: ```solidity /// Expect a given number of logs with the provided topics. function expectEmit(bool checkTopic1, bool checkTopic2, bool checkTopic3, bool checkData, uint64 count) external; /// Expect a given number of logs from a specific emitter with the provided topics. function expectEmit( bool checkTopic1, bool checkTopic2, bool checkTopic3, bool checkData, address emitter, uint64 count ) external; /// Expect a given number of logs with all topic and data checks enabled. function expectEmit(uint64 count) external; /// Expect a given number of logs from a specific emitter with all topic and data checks enabled. function expectEmit(address emitter, uint64 count) external;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partially closes #509
Solution
Implement overloads
expectEmitandexpectRevertwith thecountarg.expectEmitexpectRevert- To be done in a separate PR to make reviewing easier feat(cheatcodes): count assertion forexpectRevert#9484