Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(solc): provide remappings on unresolved import message #935

Merged
merged 3 commits into from
Mar 14, 2022
Merged

chore(solc): provide remappings on unresolved import message #935

merged 3 commits into from
Mar 14, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Mar 14, 2022 •
edited
Loading

BLOCKED BY gakonst/ethers-rs#1026 gakonst/ethers-rs#1027

Motivation

To improve user feedback on

  • unresolved imports (indicates misconfigured remappings) also provide the current remappings
  • solc install errors

Solution

@mattsse mattsse added the C-forge Command: forge label Mar 14, 2022
@mattsse mattsse force-pushed the matt/report-remappings-on-unresolved-import branch from 3f1e726 to cd7379a Compare March 14, 2022 10:10
@mattsse mattsse marked this pull request as ready for review March 14, 2022 11:54
@mattsse mattsse force-pushed the matt/report-remappings-on-unresolved-import branch from cb37b64 to dcda2d2 Compare March 14, 2022 11:58
@gakonst gakonst merged commit 62a5556 into foundry-rs:master Mar 14, 2022
@onbjerg onbjerg added the L-ignore Log: ignore PR in changelog label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-forge Command: forge L-ignore Log: ignore PR in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @gakonst @onbjerg