Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): allow ir-minimum for versions < 0.8.5 #9341

Merged
merged 6 commits into from
Nov 19, 2024
Merged

fix(coverage): allow ir-minimum for versions < 0.8.5 #9341

merged 6 commits into from
Nov 19, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 18, 2024 •
edited
Loading

Motivation

Closes #9322

Solution

@grandizzy grandizzy changed the title Issue 9322 fix(coverage): allow ir-minimum for versions < 0.8.5 Nov 18, 2024
@grandizzy grandizzy changed the title fix(coverage): allow ir-minimum for versions < 0.8.5 fix(coverage): allow ir-minimum for versions < 0.8.5 Nov 18, 2024
@grandizzy grandizzy added the T-blocked Type: blocked label Nov 18, 2024
@grandizzy grandizzy removed the T-blocked Type: blocked label Nov 19, 2024
@grandizzy grandizzy marked this pull request as ready for review November 19, 2024 06:16
zerosnacks
zerosnacks approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grandizzy grandizzy merged commit dacf341 into foundry-rs:master Nov 19, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9322 branch November 19, 2024 11:44
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy @zerosnacks
@DaniPopes @rplusq
fix(coverage): allow ir-minimum for versions < 0.8.5 (foundry-rs#…
f4eee43 
…9341)

* fix(coverage): allow ir-minimum for versions < 0.8.5

* Fix

* Remove 0.8.13 restriction, update message and sanitize for 0.8.4 if version cannot be detected

* Update crates/forge/bin/cmd/coverage.rs

Co-authored-by: DaniPopes <[email protected]>

---------

Co-authored-by: zerosnacks <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@zerosnacks zerosnacks zerosnacks approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: forge coverage --ir-minimum compilation fails with Error: Unknown key "inliner (solc < 0.8.5)
3 participants
@grandizzy @DaniPopes @zerosnacks