Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge build): err if no source file in specified paths #9329

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(forge build): err if no source file in specified paths #9329

merged 1 commit into from
Nov 15, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #9304

Opted to fail (instead warn) if no source file matches provided build paths

Solution

@grandizzy grandizzy marked this pull request as ready for review November 15, 2024 13:17
zerosnacks
zerosnacks approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are side effects of this proposed change

Supportive of this being an error rather than a warning, this is in line with other commands when specifying a path and there was no match

@grandizzy grandizzy merged commit 9d7557f into foundry-rs:master Nov 15, 2024
21 checks passed
@grandizzy grandizzy deleted the issue-9304 branch November 15, 2024 14:29
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy @rplusq
feat(forge build): err if no source file in specified paths (foundry-…
f6bef52 
…rs#9329)
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise warning if path specified in forge build does not match and fallback is triggered
2 participants
@grandizzy @zerosnacks