Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge build): add --sizes and --names JSON compatibility #9321

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Nov 14, 2024

Motivation

Related: #8794

Solution

  • Adds JSON compatible outputs + tests
  • Generalizes report type in foundry::common between SizeReport / GasReport (and other future reports)

@zerosnacks zerosnacks marked this pull request as ready for review November 14, 2024 11:58
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

crates/common/src/reports.rs Show resolved Hide resolved
@zerosnacks zerosnacks enabled auto-merge (squash) November 15, 2024 14:59
@zerosnacks zerosnacks merged commit a79dfae into master Nov 15, 2024
21 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/forge-build-json branch November 15, 2024 15:01
@zerosnacks zerosnacks self-assigned this Nov 18, 2024
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
…oundry-rs#9321)

* add --sizes and --names JSON compatibility + generalize report kind

* add additional json output tests

* fix feedback nit
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-feature Type: feature
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants