fix(forge create): set skip_is_verified_check: true #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
grandizzy
changed the title
grandizzy
changed the title
mattsse
approved these changes
Oct 29, 2024
zerosnacks
approved these changes
Oct 29, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
fix(verify): set skip_is_verified_check: true for deploy (similar to broadcast)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9219
Solution
I am not sure if any good reason to create
forge_verify::VerifyArgswithskip_is_verified_check: falseforforge createfoundry/crates/forge/bin/cmd/create.rs
Line 353 in a428ba6
when in
get_verify_argsfn they are set to truefoundry/crates/script/src/verify.rs
Line 149 in a428ba6
changing this for consistency and to solve the issue where
forge createalways prints "is already verified. Skipping verification." without performing verification. @klkvr @yash-atreya can you please chime in?